Language selection menu #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emibcn
requested changes
Oct 8, 2020
There was a problem hiding this comment.
I think it will be easier and cleare to add each language name into its own deffinition, and no need to translate them into the rest of languages. What do you think?
In the end (just before PR approval/merge), I'll make a PR against your forked repo to fix catalan ans spanish translations (my mother tongues), so they are ok before hitting master.
PS: Nice job on the Language component! 👍🏾
Closed
|
Please check now, I have made the changes accordingly and tested them. Should be all good. |
|
I've opened a PR against your fork to fix catalan and spanish translations. Merge it and then I'll merge the result here 👍🏾 |
Fix translations for catalan and spanish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR and let me know for any changes.
I have modified the currently available languages object into an array and did the relevant changes needed to handle the language change.